Refactor of Supplemental Precipitation Mod (suppPrecipMod.py) - #134
Merged
Conversation
mdeshotel
marked this pull request as draft
April 7, 2026 18:33
mxkpp
changed the title
…sts.py, symbol misspelling, and stale ewts reference.
…t_bounds", and "lon_bounds" (ignore hashes).
|
Reviewed logic paths to confirm original behavior is equivalent to new behavior. Added some fixes as shown in commits. Rebased against development. |
…y, travel recursively instead of falling back to pure equality tests after initial shallow inspection. This allows nested objects to have the numerical tolerances applied as intended.
|
All ngen-forcing pytests are passing (with tolerance) from the nwm-rte Dev Container: ( cd src/ngen-forcing && pytest )
( cd src/ngen-forcing && mpirun -n 2 pytest )@idtodd I needed to make significant changes. This is ready for your review. |
mxkpp
marked this pull request as ready for review
August 11, 2026 03:19
idtodd
approved these changes
Aug 12, 2026
mxkpp
changed the base branch from
development
to
NGWPC-7625_PI_10_ngen_forcing_refactor
August 13, 2026 18:14
|
Merging to the new refactor branch which was branched off from |
mxkpp
merged commit Aug 13, 2026
2aaee61
into
NGWPC-7625_PI_10_ngen_forcing_refactor
7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a refactor of suppPrecipMod.py that mimics the refactor that was done for forcingInputMod.py.
Additions
Removals
Changes
-Refactor suppPrecipMod.py to mimic the refactor that was done for forcingInputMod.py.
Testing
Screenshots
Notes
Todos
Checklist
Testing checklist
Target Environment support